Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created an automation to keep service tags updated. #4332

Merged
merged 10 commits into from
Nov 2, 2022
Merged

Created an automation to keep service tags updated. #4332

merged 10 commits into from
Nov 2, 2022

Conversation

samikroy
Copy link
Contributor

@samikroy samikroy commented Mar 7, 2022

Created an automation to keep service tags updated.

@NikTripathi NikTripathi added the javascript Pull requests that update Javascript code label Mar 8, 2022
@samikroy
Copy link
Contributor Author

samikroy commented Mar 8, 2022

@NikTripathi - This automation is based on PowerShell to extract azure service tags from download center and save as a json file for further analytics to refer this.
But, tagged as JavaScript. Please let me know for any modifications.

sreedharande
sreedharande requested changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@sreedharande sreedharande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to under tools. Add README, Steps to use it

@samikroy
Copy link
Contributor Author

Can you move this to under tools. Add README, Steps to use it

@sreedharande - Thank you for sharing this, will be able to similar file here :
https://github.com/samikroy/SyncMSServiceTags/blob/main/README.md

In addition, have a question - As this is a corn job (schedule) based on devops pipeline hence moving this as a tool will make it static and we will still have old file references in the rules like - #4266

Please advise.

@v-sabiraj
Copy link
Contributor

Hey @sreedharande, can you please check and provide your feedback, thanks.

@samikroy
Copy link
Contributor Author

Hey @sreedharande, can you please check and provide your feedback, thanks.

@sreedharande - Updated into tools folder as requested, please review & let me know for further updates.

@samikroy
Copy link
Contributor Author

samikroy commented May 4, 2022

@sreedharande - Could you please help with merge for this.

@NikTripathi
Copy link
Contributor

@sreedharande Please look into this.

1 similar comment
@v-marimanda
Copy link
Contributor

@sreedharande Please look into this.

@v-mchatla v-mchatla requested review from sreedharande and removed request for Amitbergman September 14, 2022 07:26
@v-mchatla
Copy link
Contributor

Hi @sreedharande
The author @samikroy already addressed your feedback. Can you please review once again and provide your approval
Thanks

@v-mchatla
Copy link
Contributor

Hi @sreedharande
It would be great if you could review the PR and provide your feedback.
Thanks

@v-mchatla
Copy link
Contributor

Hi @sreedharande
Can you please review or route to someone who can review and provide signoff.
Thanks

@v-mchatla
Copy link
Contributor

v-mchatla commented Sep 22, 2022 •
edited
Loading

Hi @sreedharande
The author @samikroy already addressed your feedback. Can you please review once again and provide your approval, so that we can merge the PR
Thanks

@v-mchatla
Copy link
Contributor

Hi @sreedharande ,
Can you please review and approve the PR
Thanks

@v-mchatla
Copy link
Contributor

Hi @sreedharande
Please review or assign someone to review this PR.
Thanks

@v-mchatla v-mchatla self-assigned this Sep 30, 2022
@v-mchatla
Copy link
Contributor

Hi @sreedharande
Please review or assign someone to review this PR.
Thanks

@v-mchatla
Copy link
Contributor

Hi @sreedharande
Please review or assign someone to review this PR. Let us know if you need any other details.
Thanks

3 similar comments
@v-spadarthi
Copy link
Contributor

Hi @sreedharande
Please review or assign someone to review this PR. Let us know if you need any other details.
Thanks

@v-mchatla
Copy link
Contributor

Hi @sreedharande
Please review or assign someone to review this PR. Let us know if you need any other details.
Thanks

@v-spadarthi
Copy link
Contributor

Hi @sreedharande
Please review or assign someone to review this PR. Let us know if you need any other details.
Thanks

@v-mchatla
Copy link
Contributor

Hi @sreedharande
Please review and provide your signoff, so that we can merge this PR.
Thanks

@sreedharande
Copy link
Contributor

@samikroy - Can you please remove .github/workflows folder. Keep your code in the parent folder. After review, we will add to workflows folder

@samikroy samikroy requested review from a team as code owners October 20, 2022 08:38
@samikroy
Copy link
Contributor Author

@samikroy - Can you please remove .github/workflows folder. Keep your code in the parent folder. After review, we will add to workflows folder

@sreedharande - Thank you for your response. Have done the changes requested, please have review & let me know.

@v-mchatla
Copy link
Contributor

Hi @sreedharande,
Author has addressed your comments. Can you please review the changes once again and provide your feedback if any.
Thanks

1 similar comment
@v-mchatla
Copy link
Contributor

Hi @sreedharande,
Author has addressed your comments. Can you please review the changes once again and provide your feedback if any.
Thanks

@v-mchatla
Copy link
Contributor

Hi @sreedharande,
It would be great if you can spare sometime on this and provide your feedback.
Thanks

@sreedharande sreedharande merged commit 6a1e980 into Azure:master Nov 2, 2022
@samikroy
Copy link
Contributor Author

samikroy commented Nov 4, 2022

@sreedharande & @v-mchatla - Thank you for the approval & merge.
As requested earlier comment,
the workflow file was moved to the parent folder and was mentioned to be moved to the workflow folder after the merge.
Could you please help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreedharande sreedharande sreedharande approved these changes

@v-rucdu v-rucdu v-rucdu left review comments

@aprakash13 aprakash13 Awaiting requested review from aprakash13

@ashwin-patil ashwin-patil Awaiting requested review from ashwin-patil

@oshezaf oshezaf Awaiting requested review from oshezaf

@petebryan petebryan Awaiting requested review from petebryan

@preetikr preetikr Awaiting requested review from preetikr

@sagamzu sagamzu Awaiting requested review from sagamzu

@shainw shainw Awaiting requested review from shainw

@thmcelro thmcelro Awaiting requested review from thmcelro

@YaronFruchtmann YaronFruchtmann Awaiting requested review from YaronFruchtmann

@oshvartz oshvartz Awaiting requested review from oshvartz

@ShaniFelig ShaniFelig Awaiting requested review from ShaniFelig

@laithhisham laithhisham Awaiting requested review from laithhisham

Assignees

@sreedharande sreedharande

@v-rucdu v-rucdu

@v-mchatla v-mchatla

Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@samikroy @v-sabiraj @v-marimanda @v-mchatla @NikTripathi @v-spadarthi @sreedharande @v-rucdu